Localized terms and the page title doesn't work with the alternative "Taxonomy term" view

[laryn]

I'll try to get more information noted but wanted to write this down before I lost it: it seems that a vocabulary that is set to "Localization" as the mode of translation doesn't work quite perfectly with the "Page title" block that is available in the Layout. It always displays the source language for the Page Title.

[laryn]

Interestingly, I was poking around and made a little custom function in a module to play with this, and the following code implemented as a block and placed on the page is enough to get the "Page title" block and the title in the browser tab to localize:

  function custommodule_termname_block_view( ) {
    if (arg(0) == 'taxonomy' && arg(1) == 'term' && is_numeric(arg(2))) {
      $tid = arg(2);
      $term = taxonomy_term_load($tid);
      $term = i18n_taxonomy_localize_terms($term);
      backdrop_set_title($term->name);
    }
  }

I'm not sure where this type of thing should actually go. I should note that I am working on a site that uses the "Taxonomy Term" alternative view rather than the "out of the box" term pages. I don't know if that makes a difference.

[laryn]

Just ran into this again -- thank you past self! 😂

[indigoxela]

What are the steps to reproduce? A localized term (or translated? both?) and use it directly as a Layout title - in the Layout UI?

Some more details could be helpful here.

[indigoxela]

This is what I did to reproduce (wasn't able to):

• Created a layout for term listing pages (path: taxonomy/term/%)
• Checked the default title for a localized term - works :+1:
• Added a block of type "Page title", checked for a localized term - works :+1:

@laryn what am I missing?

[laryn]

@indigoxela I’ll try to get steps to reproduce today. It happened twice to me I just need to figure out what else I did in between your steps!

[laryn]

@indigoxela It turns out that this is important after all:

I should note that I am working on a site that uses the "Taxonomy Term" alternative view rather than the "out of the box" term pages. I don't know if that makes a difference.

The problem exists even without the Page Title block as long as the alternative view (which ships with core but is disabled by default) is used.

[indigoxela]

Ah, we're getting closer. The problem isn't the layout, nor the title block, it's the fact that the title gets set via a views contextual filter - and that's not accessible for i18n.

Did that ever work in D7? UPDATE: yes, that works in D7.

[indigoxela]

This is what I have so far.

I've no clue why/how that works in D7, but found a workaround. (My favorite complex "darlings" i18n and views give me a hard time.)

This will need thorough testing an possibly a new functional test.

[laryn]

Spitballing here, but the view does try to override the title:

Can we figure out which function does that override substitution and see if the result can be localized right there?

[indigoxela]

the view does try to override the title

Yes, that's clear, and the substitution works fine, but in B i18n isn't able to replace that with the localized variant without extra code.

Can we figure out which function does that override substitution

Sure, that's views_handler_argument::get_title(). But that doesn't explain why things are different in B compared to D7.

Did you find the time yet, to actually test the PR?

[indigoxela]

Here's the problem: https://github.com/backdrop/backdrop-issues/issues/5516

There's no "label callback" for entities in Backdrop, that's why the i18n_taxonomy code never runs. Views titles set via arguments might just be the tip of the ice-berg. But at least for that we have a workaround. We'll see what pops up in the future.

[indigoxela]

@laryn have you already been able to test this PR?

[laryn]

@indigoxela Sorry for the delay, but yes, I have now tested and this PR is working.

[indigoxela]

@laryn also sorry for the delay - I just realized that I forgot to merge the PR.