i18n_string localized term translation doesn't use CKEditor for description

backdrop-contrib / i18n

Collection of modules to extend Backdrop CMS multilingual capabilities

https://backdropcms.org/project/i18n

GNU General Public License v2.0

2 stars 5 forks source link

i18n_string localized term translation doesn't use CKEditor for description #66

Closed laryn closed 3 years ago

laryn commented 3 years ago

I noticed when translating localized terms that the description displays HTML code instead of using the CK Editor as expected. PR coming.

indigoxela commented 3 years ago

@laryn many thanks for your PR, I'll look into this ASAP, but maybe not before weekend.

laryn commented 3 years ago

Hmm... it's actually not working completely. I hadn't actually tried saving the translation, which produces an SQL syntax error with this PR.

indigoxela commented 3 years ago

@laryn should be fixed in 16c2a2e1. Please test thoroughly, the automated tests are passing, but "human eyes" still might find something. :smiley:

laryn commented 3 years ago

Manually patched my dev site and did some testing -- basic functionality is looking good! A few visual/UI suggestions that come to mind as I am testing:

can the submit button be wrapped in a '#type' => 'actions' array? I think this gives the button more consistent styling with the rest of the UI
Adding the CKEditor interface also adds "Formatting options" so the manually added description is duplication:
- The CKEditor editing window opens very narrow, it should maybe be made taller by default:

indigoxela commented 3 years ago

...A few visual/UI suggestions that come to mind...

@laryn many thanks for testing. The visual glitches should be fixed in 11ff8c9.

laryn commented 3 years ago

Looks great!