search

backdrop-contrib / ip_blocking

Enables blocking of IP addresses.
GNU General Public License v2.0
0 stars 2 forks source link

Consider moving main management page to admin "User Accounts" menu #14

Open bugfolder opened 2 years ago

bugfolder commented 2 years ago

Currently, the main management page for this module is in the admin Configuration menu, at admin/config/people/ip-blocking/main, along with the settings tab at admin/config/people/ip-blocking/settings.

I agree that the settings page belongs there. However, the "Main" page seems to be a better fit for the "User Accounts" menu, which currently contains "Add user accounts", "Manage user accounts", and (if IP Address Manager is enabled), "IP Addresses". So I suggest moving the main page to admin/people/ip-blocking, titled "IP Blocking" or "Manage IP Blocking".

The rationale being that pages in admin/config are typically things you set once, then never touch again, while day-to-day management pages go in one of the other admin menus, and "User Accounts" feels like the best fit.

And then the settings page could simply be (appropriately) at admin/config/people/ip-blocking.

findlabnet commented 1 year ago

Sorry for my late reply, these have been very busy months. I'm not sure if it's right to split the module form into two menu routes. The same top-level route - admin/config/people - is the base for my other modules, such as "Antiscan" and "Login allowlist". Perhaps we need to consider some special route for security-related modules.