Fix JS code duplication between the main module and the markercluster submodule

backdrop-contrib / leaflet

Backdrop CMS Integration with the Leaflet map scripting library.

https://backdropcms.org/project/leaflet

GNU General Public License v2.0

2 stars 2 forks source link

Closed indigoxela closed 7 months ago

indigoxela commented 3 years ago

While working on the libraries updates, I found some code duplication. It might be worth it to de-duplicate. Not sure yet, how hard that might be.

indigoxela commented 1 year ago

See also:

The word "refactor" is threatening... a huge task for a single maintainer. :stuck_out_tongue_winking_eye:

indigoxela commented 7 months ago

Years later... it's really time to address this problem. Still a huge task.

indigoxela commented 7 months ago

Still a way to go and a lot more to test, but it seems functional... :crossed_fingers:

indigoxela commented 7 months ago

There are still some open question re markercluster groups and custom icons, but all the things I was able to test work just fine.

Not that everything's perfect now with js in this module, it's just a little less of a monster now. :wink: