search

backdrop-contrib / leaflet

Backdrop CMS Integration with the Leaflet map scripting library.
https://backdropcms.org/project/leaflet
GNU General Public License v2.0
2 stars 2 forks source link

Remove dependency on libraries module. #6

Closed tkcent closed 3 years ago

tkcent commented 5 years ago

Looks like all the necessary changes have been made to support core library functionality in Backdrop.

https://backdropcms.org/project/libraries

https://github.com/backdrop-contrib/leaflet/commit/f7b8cee373ffbdfeb865703c03df56cb3a8a556a#diff-a95cc789b5fe98e3c30c56120375cd19

earthday47 commented 5 years ago

@tkcent this looks good to me, one request - could you also include removing all the commented lines related to libraries?

tkcent commented 5 years ago

@earthday47 Looks like gifad was the one who did the major work of commenting out the lines. Maybe they should be the one to tackle this?

tkcent commented 5 years ago

@earthday47 Just noticed the profile for gifad doesn't seem to exist. I can give it a try. As long as I'm removing commented lines, nothing should break, right? ;)

earthday47 commented 5 years ago

@tkcent I think gifad is their Drupal username... I'm the only maintainer of the Backdrop port I guess 🤷‍♂ Go for it, commented lines shouldn't be committed anyway, that's why we have Git :)

indigoxela commented 3 years ago

In the meantime the dependency has been removed. Not only in the info file, but also in hook_requirements, so this pull request is obsolete now (and conflicts anyway). Many thanks for providing, though.