backdrop-contrib / mailchimp

Provides integration with the MailChimp email delivery service
GNU General Public License v2.0
1 stars 0 forks source link

Bundle the mailchimp library (if it is GPL compatible) #5

Open jenlampton opened 5 years ago

jenlampton commented 5 years ago

I got a headache reading the installation instructions on the readme page. If possible, we should spare our users from that madness and bundle a working version of the mailchimp library into our module. This would save the non-technical users from needing to understand how to do it, and saving our pros the headache of needing to do the same thing every time, and saving everyone the headache of ever having a newer version of the library not work with the older version of the module.

Retsell commented 4 years ago

In the meantime, how IS it supposed to work? There's no Library folder in Backdrop to put the Mailchimp library in. And even if you make one, to enable Mailchimp in Backdrop requires the Entity_metadata_wrapper which is deprecated in Backdrop.

The instructions on the Backdrop Mailchimp project page are clearly for Drupal and do not apply to Backdrop. Would love to hear if ANYONE has this working in Backdrop??

ghost commented 4 years ago

I started trying to do this, but since the library hooks in core don't support PHP libraries, then this will take a lot more work than just adding the files to the repo (e.g. we'd need to find everywhere where the MailChimp library is used and manually include/require the necessary files...).

ghost commented 4 years ago

Here's what I've done so far in case it helps someone else get the rest of the way: https://github.com/backdrop-contrib/mailchimp/pull/7

I chose v1.0.8 of the library to include as that's the first version with a bundled download that doesn't require Composer to install (and the reason for that is all previous releases had a security issue, so their bundled packages were removed).

docwilmot commented 1 year ago

Had a look at bundling Mailchimp, but found that we now need to bundle Guzzle as well. So new branch bundle does just that. This module doesnt seem to be in great demand so will leave this until someone wants and tests it.

docwilmot commented 5 months ago

Another update, branch 5.7 is the latest, bundles latest D7 code as of today, and the V2 MC library which uses the V3 MC API.

This module doesnt seem to be in great demand so will leave this until someone wants and tests it.

Same