search

backdrop-contrib / manualcrop

The Manual Crop module exposes a set of image style effects that allow you to crop (and scale) an image after uploading.
GNU General Public License v2.0
1 stars 1 forks source link

Separate fields with different supported crops deletes crops if same image used twice #21

Open laryn opened 3 years ago

laryn commented 3 years ago

If you have a content type with two different image fields, and each field has a different list of enabled crops, then on crop form submission, the non-shared crops will be deleted on those files.

I've created a patch which replaces the delete and subsequent update operations with a single merge operation, which should negate this problem.

From @n_potter in the D7 queue

laryn commented 3 years ago

Testing needed: https://github.com/backdrop-contrib/manualcrop/tree/1.x-issue21

Patch by @n_potter, @TessaBakker, @sinniger, @candelas, and @Nitebreed in the D7 queue. Thanks!

laryn commented 1 year ago

Now we have a separate commit that may solve this in a different way. If we test after this change and the issue is fixed we can close this branch without merging.