Support Open Graph Protocol standards

backdrop-contrib / metatag

Add structured metadata, aka "meta tags", for various pages on your site.

GNU General Public License v2.0

3 stars 15 forks source link

Support Open Graph Protocol standards #28

Closed ghost closed 2 years ago

ghost commented 5 years ago

This module doesn't output the correct code for Open Graph Protocol standard metatags. Namely it should output:

The 'property' attribute for the meta tag (e.g. <meta property="og:title" content="The Rock" /> (it currently outputs the 'name' attribute instead))
The 'prefix' attribute for the html tag (e.g. <html prefix="og: http://ogp.me/ns#">)

These examples come from: http://ogp.me/

ghost commented 5 years ago

Added PR.

jenlampton commented 5 years ago

Nice, thanks for the PR!

jackaponte commented 4 years ago

Thanks for filing this PR, @BWPanda; I encountered these issues myself! Since there hasn't been a new release of this module I'm going to try to patch my site from your PR.

jackaponte commented 4 years ago

To be a bit more clear, in the module's current state, the og:image property doesn't get read by Facebook Open Graph at all.

jenlampton commented 4 years ago

@jackaponte This PR has been merged and should be included in the latest release. Are you still having problems after updating to latest stable?

jackaponte commented 4 years ago

Ah, whoops, thanks for that heads up Jen--somehow I missed that a new stable release was out! Updating fixed that problem.

jenlampton commented 3 years ago

This caused regressions in a handful of the other metatags, since it changed all of them from name to property. I expect only some of them need to be changed, so revering that change to re-evaluate.

indigoxela commented 3 years ago

The regression gets fixed in this follow-up. This issue here could get closed by someone with sufficient permissions.