search

backdrop-contrib / metatag

Add structured metadata, aka "meta tags", for various pages on your site.
GNU General Public License v2.0
3 stars 15 forks source link

Fixes #51 error when missing field_image #52

Closed robertgarrigos closed 1 year ago

robertgarrigos commented 4 years ago

opengraph submodule put [node:field_image] as default token to image and image url settings, even if its not set in the system. I know that backdrop ships with this field, but it might be deleted or changed. In that case, the settings form always fill in the default value, and thus fails, every time you update it.

I propose to not provide that default, as anyway, this is a very customizable module and you have to set it anyway

Fixes https://github.com/backdrop-contrib/metatag/issues/51

jenlampton commented 3 years ago

I propose to not provide that default

The current PR comments out the problematic lines instead of removing them, so it wouldn't be accepted even if we did decide not to include a default image token.

jenlampton commented 3 years ago

Adding Fixes https://github.com/backdrop-contrib/metatag/issues/51 to the issue summary so GitHub will link this PR to it's matching issue.

quicksketch commented 1 year ago

Yeah, maybe a compromise approach would be to wrap that in an if statement? Use the field_image field if it exists on the site?

quicksketch commented 1 year ago

I reopened the parent issue at https://github.com/backdrop-contrib/metatag/issues/51 but we can close this PR. I'll file a follow-up.