Issue #67: Fix double function declaration

backdrop-contrib / metatag

Add structured metadata, aka "meta tags", for various pages on your site.

GNU General Public License v2.0

3 stars 15 forks source link

Issue #67: Fix double function declaration #86

Closed indigoxela closed 1 year ago

indigoxela commented 1 year ago

Fixes #67

yorkshire-pudding commented 1 year ago

I've tested on the local that had the issue and re-enabled metatag_views and it's fine. I've also tested the update on another site with metatag and it works there too.

Egarbeil commented 1 year ago

I ran into this on one of my sites in development as well updating to the latest release (1.22.2) . The fix works and the site is now back up. I just commented out the function for now. Most likely will have to do so on all backdrop sites until this makes it into the next release.

quicksketch commented 1 year ago

A couple things needed here:

If Views prior to Backdrop 1.22.1 was not including metatag.views.inc we should add path to metatag_views_api() so that the .inc file gets pulled in for those older versions.
The metatag.views.inc instance of metatag_views_views_plugins() had a drupal_get_path() in it.

quicksketch commented 1 year ago

I made a follow-up commit at https://github.com/backdrop-contrib/metatag/commit/3f0f9928c42256839dde2f206b1c384e51e6a902 that fixes the above two points.