search

backdrop-contrib / mini_layouts

Provide blocks which allow positioning content within them in layouts.
GNU General Public License v2.0
7 stars 4 forks source link

Tweak user interface #26

Closed indigoxela closed 2 years ago

indigoxela commented 2 years ago

Hi @docwilmot,

this module is a great enhancement for the core layout system. :+1:

I've noticed some room for improvement in the UI: the icons aren't very helpful:

mini-layout-icons

These caused me some head-scratching - "heck, what will these look like?" :smirk: Not sure, how much effort it would be to add custom icons, and if it's worth it.

Another thing I've noticed is that the layouts this module ships with use both classes, "container" and "container-fluid" - to my knowledge these classes are mutually exclusive (fixed width vs. flexible width). (Something that's also wrong in core templates, but that's another issue.)

mini-layout-both-classes

In real life it's more likely that people construct their own (flexi) templates, anyway, so both findings aren't big problems.

docwilmot commented 2 years ago

Thanks @indigoxela we considered the OOTB layouts issue here: https://github.com/backdrop-contrib/mini_layouts/issues/12 I think this was the best compromise we could come up with. In short, flex layouts dont have icons, and regular layouts wont auto-install when this module is enabled.

indigoxela commented 2 years ago

flex layouts dont have icons, and regular layouts wont auto-install...

So custom icons wouldn't be possible at all, is that correct?

How about the CSS classes (container + container-fluid instead of just one of them)? Would it be feasible to just use one of them? It's probably impossible to configure them via UI, I guess.

docwilmot commented 2 years ago

So custom icons wouldn't be possible at all, is that correct?

Yes that was the conundrum here.

The container issue is from core flexible templates, not this module, unfortunately. Here: https://github.com/backdrop/backdrop/blob/c7ebb0c40f59ca9fc0095d788483142efc7d9161/core/modules/layout/layout.theme.inc#L347

indigoxela commented 2 years ago

I see, so both, icons and css classes are out of scope of this module. No problem, it's easy to delete the templates and build custom flexis, anyway.