backdrop-contrib / mini_layouts

Provide blocks which allow positioning content within them in layouts.
GNU General Public License v2.0
7 stars 4 forks source link

Improve display of block ID #29

Closed stpaultim closed 4 months ago

stpaultim commented 2 years ago

I just opened up a mini-layout for the first time in a while and found the display of the block ids a bit jarring.

image

I don't have specific ideas yet for improvement, but will try to think of something constructive to suggest and/or to work on a PR sometime soon.

argiepiano commented 2 years ago

This looks like a bug to me... it's showing the UUID instead of human labels. I wonder if something changed through recent Layout updates that is causing this layout to show this way?

stpaultim commented 2 years ago

@docwilmot - Is this a bug?

I've included Mini Layouts as a dependency for my "Welcome" module, because I wanted to place a footer blocks with columns into the default layouts that come with Backdrop CMS. I also wanted to be consistent across all layouts and edited in one place.

I'm doing this: image

stpaultim commented 2 years ago

@docwilmot - Thanks. This looks much better. Same mini-layout as original post now looks like this:

image

stpaultim commented 7 months ago

@docwilmot Has there been a regression. I'm testing module today and getting this when using one of the provided mini-layout templates for the first time.

image

docwilmot commented 7 months ago

Cant reproduce this @stpaultim, it works fine for me, latest Backdrop dev, latest ML, PHP 8.1 and 8.2

stpaultim commented 7 months ago

I'll try again to reproduce.

stpaultim commented 7 months ago

@docwilmot I'm sorry, this was my fault. I thought I had tested with the dev branch, but in fact I think I was testing with the latest release.

I have confirmed that the latest release is still performing as described in this issue, but the dev branch has fixed this issue.

Maybe we could issue a new release, since this is a pretty ugly bug that is part of the recommended release.

stpaultim commented 4 months ago

I am going to reopen this issue. Because, this is still what users are getting with the official release. It has been fixed in dev, but most users don't know that.

image

Atten: @docwilmot - can we get a new release.

stpaultim commented 4 months ago

@docwilmot Thanks for the release.

I think we can close this again.