search

backdrop-contrib / og

The Organic Groups module provides users the ability to create, manage, and delete 'groups' on a site.
GNU General Public License v2.0
1 stars 8 forks source link

Issue #94: Adding new view #100

Closed stpaultim closed 2 years ago

stpaultim commented 2 years ago

Fixes: https://github.com/backdrop-contrib/og/issues/94

argiepiano commented 2 years ago

@stpaultim, thank you! Looks good, but a few suggestions:

  1. To keep in line with blocks provided by other OG views (e.g. admin/structure/views/view/og_all_user_group_content), do not use a block title. Leave as "None" in the Title field
  2. Also in line with other OG blocks, use an Unformatted List format (instead of a table)
  3. And thirdly, also in line with the style of the other OG views, change the name of the view to "OG groups" instead of "OG Groups" (lowercase for the second word)
stpaultim commented 2 years ago

@argiepiano - I made the suggested changes.

I had given it a block title, so that it's easier to use without customizing it. Same as the table format. I recognize that this is not the way the other views are, but it's possibly an improvement. ;-)

BUT, I'm happy to put that discussion off for later and first just make sure we can get this working properly.

See my note. When I installed this view on a site without any existing groups, it showed the wrong content. I need to test further and possibily make it better.

argiepiano commented 2 years ago

Since the OG Example module includes such a view (and given that the view is pretty straightforward - it just contains a filter for the group_group field being true) I will go ahead and close this PR. Please see the discussion in the linked issue #94

Fee free to reopen if you feel strongly about this view.