search

backdrop-contrib / og

The Organic Groups module provides users the ability to create, manage, and delete 'groups' on a site.
GNU General Public License v2.0
1 stars 8 forks source link

Issue #32. Check that group field type is not empty #71

Closed argiepiano closed 2 years ago

argiepiano commented 2 years ago

Fixes #32 for OgGroupAndUngroup tests

This small tweak of og_is_group_audience_field() is necessary in PHP 7.4+ in order for OgGroupAndUngroup to pass.

This tweak also helps catch typos in field names, or wrong field names - it avoids throwing an Exception for a null array offset in PHP 7.4+

argiepiano commented 2 years ago

IMPORTANT: for this fix to have an effect and allow OgGroupAndUngroup to pass, PR #64 MUST be merged first.

laryn commented 2 years ago

I merged #64, then closed and reopened this PR to trigger tests again.

laryn commented 2 years ago

✅ Organic groups: OG group and ungroup (OgGroupAndUngroup) 28 passes, 0 fails, and 0 exceptions. [10.078s]

laryn commented 2 years ago

Thanks @argiepiano!