Improve OG field setting UI

[argiepiano]

The OG field settings UI leaves much to be desired. It's extremely confusing, as the "Add field" button appears below the vertical tabs, leading one to believe that the vertical tabs do something to the configuration, while in fact they are only informational.

I propose the following changes. From the current:

To one with better organization and titles:

I will submit a PR shortly for this. Feedback ppareciated!

[argiepiano]

PR #96. Feedback please!

[stpaultim]

@argiepiano - I'm working on some suggestions for this page.

Is it just me, or does this statement not make sense in this location.

[argiepiano]

That little phrase changes depending of the OG field you pick. It's a short explanation of what the field does. In this case it's telling you that adding a "Groups audience" field to an entity will do two things: it will make this entity a "group content" entity, and (2) it will determine to which group this "group content" is assigned.

Perhaps there is a better way to explain this?

[stpaultim]

Here is something I'm working on.

[stpaultim]

@argiepiano I've provided an new PR with some changes. My PR should include the changes in your original PR.

Feel free to edit my PR or use parts of it.

[argiepiano]

@stpaultim I think this looks good and makes the UI easier to understand. I'd like to give @olafgrabienski, @VasasA, @laryn and @schoenid an opportunity to chime in if they wish, since they've been involved in other OG issues.

[VasasA]

OG module is compex. So the more informative pages are very useful. I like @stpaultim solution (PR #99). Some little things:

• There are two unnecessary space characters in line 1033 in og_ui.admin.inc
• In Firefox the position of the help list is too left. (Correct in Chrome.)

[olafgrabienski]

I'd like to give [...] an opportunity to chime in

I like the overall direction, especially the collapsible help section. I'd love to have a closer look, but I'm not sure if I find time the next days. We'll see!

[stpaultim]

@VasasA and @olafgrabienski - Thanks for feedback. Those items should all be fixed.

[schoenid]

Looks great!

[argiepiano]

Thanks @stpaultim - I added one small comment. Let's wait until you make that small change and @olafgrabienski can also take a look before merging. Thank you all!

[olafgrabienski]

Thanks for your patience, Alexjandro and Tim! @stpaultim I've added some minor comments directly in the PR.

[stpaultim]

@argiepiano - I've updated the PR to include the last changes that @olafgrabienski suggested.

Do we want to discuss the "Select one" label now or hold off?

I'm of the mind, that I would not want to this delay a beta release. I think that the sooner we get a beta release, the sooner we get more testers and more feedback. I would focus on changes right now that are blockers for a beta release.

[argiepiano]

Thank you, @VasasA, @olafgrabienski and @stpaultim!