backdrop-contrib / og

The Organic Groups module provides users the ability to create, manage, and delete 'groups' on a site.
GNU General Public License v2.0
1 stars 8 forks source link

The self test needs the Entity reference prepopulate module #98

Closed VasasA closed 2 years ago

VasasA commented 2 years ago

The "OG non members publishing" self test (admin/config/development/testing) uses the Entity reference prepopulate module, but it isn't a dependency module in the og.info. The test works if you put the prepopulate module in the modules directory. Should we mention this in the README.md? In the og.test:

    $modules[] = 'entityreference_prepopulate';
    parent::setUp($modules);
argiepiano commented 2 years ago

Hmmm... I'm not sure this is necessary. Automated tests are there to be run in the GHA environment. The GHA script automatically installs all dependencies needed for the test. Since 99% of users of OG won't be concerned about running an automated test, I would think that including this info in the readme is not needed - while it won't hurt, it may confuse users not familiar with automated tests.

If anything, we could add a comment to the test prompting developers interested in running the test locally to put that module in the modules folder.

@laryn, what do you think?

VasasA commented 2 years ago

We could complete the description of the test in the og.tests.info:

name = OG non members publishing
description = Grant access to non members users publishing content with the group passed in the query string. <a href="https://backdropcms.org/project/entityreference_prepopulate/">Entity reference prepopulate module</a> is required!
argiepiano commented 2 years ago

Sounds like a great idea. Care to prepare a PR?

VasasA commented 2 years ago

I done it :+1: I was happy to help. :smile:

argiepiano commented 2 years ago

Thank you, @VasasA!