Add dependency on Entity Plus

[laryn]

Removing the EMW dependency ended up causing a bunch of loose ends that nobody seems to have time to comb through. I'm planning to add a dependency on Entity Plus at this point which seems to solve a handful of issues in the queue and will make things simpler for me.

The biggest issue will be figuring out how to introduce a dependency when many people already have the module installed. How can we make sure they install the latest version of Entity Plus before upgrading Paragraphs?

[docwilmot]

Would be good to summarize the loose ends to see if we can work on keeping this light, without EP getting involved. I'm willing to help get that done in the next few days.

[laryn]

@docwilmot These "has PR" issues are all solved if I add Entity Plus (currently the entityplus branch of Paragraphs):

• https://github.com/backdrop-contrib/paragraphs/issues?q=is%3Aissue+is%3Aopen+label%3A%22has+pr%22

I'm not sure what it would take to rework this module to solve all of those without it.

[laryn]

So in early testing, it looks like upgrading Paragraphs to a version that is dependent on Entity Plus (if you don't have Entity Plus installed) crashes any page that has a Paragraph on it (as expected: Error: Class 'ParagraphsItemController' not found). The admin pages still work, and Entity Plus can be installed/enabled through the UI if you navigate to the admin page after the fatal error. Not ideal, of course, but recoverable.

It would be a good idea if we go this route to add a red error button to the admin toolbar if Paragraphs is installed but Entity Plus is not, to make sure it is clear what the issue is. And if you do the upgrade through the UI, you should see the red warning button immediately.

[herbdool]

Maybe some warning can be added to the install file. It might help people find out what is wrong.

[klonos]

Actually this would be a great opportunity to test how the Project Installer/Updater behaves when dependencies are introduced (if it is decided to introduce the dependency after all that is).

...I would expect the update to show as available, but denoting that there is a missing dependency. When the update proceeds, I would expect any dependencies to be downloaded and installed automatically.

[laryn]

So I tested as follows:

• Downloaded an earlier version of Manual Crop and edited out the dependency lines in the .info file.
• Installed and enabled it
• Did an upgrade via the Project Installer to the most recent version (which has dependencies in the .info file)

On the update step it halted and indicated dependencies weren't met:

So this would work similarly, I think. I also added (in the entityplus branch) a red warning flag in the admin toolbar/status page if Entity Plus was not installed.

[herbdool]

That's a smart approach. Looks like it works then.

[laryn]

It works, kind of. Ideally the requirements check would happen before it replaces code (right now it happens after it replaces code but before it tries any potential database updates). But this may be the best we can do.

...I would expect the update to show as available, but denoting that there is a missing dependency. When the update proceeds, I would expect any dependencies to be downloaded and installed automatically.

@klonos Yes, ☝️ would be ideal!