search

backdrop-contrib / paragraphs

Paragraphs module to control your content flow
https://backdropcms.org/project/paragraphs
GNU General Public License v2.0
5 stars 11 forks source link

views_handler_relationship issue #59

Closed laryn closed 4 years ago

laryn commented 4 years ago

Reported on the Forum by @fjeder:

Warning: Declaration of paragraphs_handler_relationship::options_form(array &$form, array &$form_state) should be compatible with views_handler_relationship::options_form(&$form, &$form_state) in require_once() (line 6 of /<site>/modules/paragraphs/views/paragraphs_handler_relationship.inc).

laryn commented 4 years ago

This is due to recent changes in the D7 version (adding "type hinting" in the function declaration).

Ideally this type hinting should be added/fixed in Views as well -- I'll file an issue to see whether that is something that might happen relatively soon, otherwise we can follow D7 Paragraph's lead and remove the type hinting:

@DamienMcKenna: "Looking at the layers of the problem, fixing it in Views will create a tidal wave of similar bugs in other modules and custom code. Given D7 is nine years old at this point, I think it's a little late for such an ecosystem-shaking change." (comment)

laryn commented 4 years ago

Looks like at the earliest this would be in Backdrop 2.0 so we should revert this for now.