search

backdrop-contrib / paragraphs_jquery_ui_accordion

An accordion display for paragraph title and description content on Backdrop CMS
https://backdropcms.org/project/paragraphs_jquery_ui_accordion
GNU General Public License v2.0
1 stars 4 forks source link

Start Closed checkbox not changing anything #13

Closed keiserjb closed 1 year ago

keiserjb commented 1 year ago

I had a strange problem this afternoon when I wanted to have an accordion start open. Start closed is not checked. My config file has "startclosed": 0, in it.

However after going to the page with the accordion, it is still closed. When I view source of the page and search for closed I see "startclosed":true.

It shouldn't ever say true, it should either be a 0 or 1.

I am quite confused by this. I should note that the Auto scroll checkbox does the same thing.

yorkshire-pudding commented 1 year ago

I think I might have found why this is; perhaps they've never worked but I've never noticed before. I'll do some testing.

yorkshire-pudding commented 1 year ago

@keiserjb - I've added a PR that fixes the settings not being passed.

~~Autoscroll is still not working and I can't figure out why not; it seems to be to do with the event not firing as I put a load of console.log() lines in and they were only triggered when the page loads. Unless you know of a quick fix, I'm minded to merge this one so that startclosed works and open a separate issue for autoscroll.~~

yorkshire-pudding commented 1 year ago

Autoscroll now works

alanmels commented 1 year ago

@keiserjb Thanks for reporting this issue. @yorkshire-pudding Unfortunately, I don't have time to test this, if it's working for you, can you merge the changes and release a new version?

yorkshire-pudding commented 1 year ago

@alanmels - yes, of course. As a courtesy, I'm waiting for @keiserjb to confirm that it works before merging and releasing.