search

backdrop-contrib / project

Projects associate a code-based project with releases and power the update server of BackdropCMS.org
2 stars 10 forks source link

Add support for Code Sign #29

Open jlfranklin opened 5 years ago

jlfranklin commented 5 years ago

Codesign is an upcoming feature of Backdrop that enables module and module package signing. A submodule of Project should generate the signatures.

jlfranklin commented 5 years ago

Rebased patch in https://github.com/backdrop-contrib/project/pull/30.

quicksketch commented 5 years ago

This is looking great @jlfranklin! I read through the code additions and I think this is pretty much good to go. I added a commit to fix up some code style issues, plus it seems as though you may have been aware of an issue when downloading a project and then attempting to clean up the temporary file.

Some additional comments on things that still need addressing posted to the PR at https://github.com/backdrop-contrib/project/pull/30#pullrequestreview-279906930.

quicksketch commented 4 years ago

I merged in https://github.com/backdrop-contrib/project/pull/30 with the plan to fix my minor gripe about unnecessary pound/hash symbols after merging.