search

backdrop-contrib / radix

A responsive base theme with Bootstrap and Sass for Backdrop CMS.
http://docs.radixtheme.org
GNU General Public License v2.0
4 stars 2 forks source link

header block settings not respected #8

Closed jenlampton closed 3 years ago

jenlampton commented 9 years ago

Things I've noticed with the header block:

Menu: Radix seems to overwrite the menu setting (set via the layouts UI) with the main menu in 'radix_preprocess_header'. It looks like a specific menu is pulled out with variable_get() instead.

Logo: it looks like there's no option to show a logo in this header. Is that intentional? Is it a bootstrap thing to have your logo be done with CSS instead of having an IMG tag on the page?

(If things are done correctly with Backdrop, there should be no calls to variable_get() anywhere, since we now use config, so all calls to variable_get should be removed. See https://github.com/backdrop-contrib/radix/issues/15)

jenlampton commented 9 years ago

I found a better fix for this... since the menu was rendered before it got to this template, what we need to do is just override that theme hook suggestion: links__header_menu. FIling a new PR shortly...

jenlampton commented 9 years ago

eh, well it's not what I wanted. but it works :) Re-opening so you can have another look.

jenlampton commented 9 years ago

new PR is better because we aren't rendering the whole menu twice. Performance FTW.

jenlampton commented 9 years ago

Updated PR includes fix for logo too.

jenlampton commented 8 years ago

Just a note that the fix that was merged in https://github.com/backdrop-contrib/radix/issues/14 added the appropriate classes to the UL, but the classes on each menu link (like expanded) aren't added. We'll likely need to revisit how the header menu is added in core (see https://github.com/backdrop/backdrop-issues/issues/1270) or render the menu twice, once using theme_links (in core) and once using menu_tree (in Radix).

jenlampton commented 3 years ago

Closing since all PRs were merged.