search

backdrop-contrib / reference

Defines a field to allow Backdrop entities to reference each other.
GNU General Public License v2.0
4 stars 6 forks source link

Issue #21: Moving reference.views.inc into the views directory so that it will get included by views. #57

Closed hosef closed 3 years ago

hosef commented 3 years ago

Issue #21: Moving reference.views.inc into the views directory so that it will get included by views.

jenlampton commented 3 years ago

I haven't had any problems with the file not getting picked up. Isn't any file ending in .views.inc in the module directory picked up by views? Usually the only code that goes into the views directory are PHP classes that are specific to views. Having the *.views.inc file in the root directory is also more useful (to humans) because it indicates that the module contains views integration at first glance. I don't think I'm in favor of this change.

hosef commented 3 years ago

Isn't any file ending in .views.inc in the module directory picked up by views?

No, it only looks in the directory specified by your path in hook_views_api

jenlampton commented 3 years ago

This is ringing a bell. Is the module broken for you now without this change? I'll check my sites that are using reference views and see what state they are in too...

hosef commented 3 years ago

Yeah, I checked that it did not show up, and then moved the file and it worked.

hosef commented 3 years ago

https://github.com/backdrop-contrib/reference/issues/21#issuecomment-771976013

jenlampton commented 3 years ago

Fair enough.