Change iframe to dialog approach?

backdrop-contrib / references_dialog

Extends reference fields by adding links to add, edit, and search for references through a dialog.

https://backdropcms.org/project/references

GNU General Public License v2.0

1 stars 3 forks source link

Change iframe to dialog approach? #14

Closed robertgarrigos closed 1 month ago

robertgarrigos commented 1 year ago

As @indigoxela and @herbdool stated here (https://github.com/backdrop-contrib/references_dialog/issues/4#issuecomment-924629258 ) and here (https://github.com/backdrop-contrib/references_dialog/issues/4#issuecomment-925025131) we might want to change the iframe approach to the dialog. I don't have a strong opinion, but I tend to think that it's neater to use the dialog=true approach.

What are your thoughts?

Thanks.

indigoxela commented 1 year ago

What are your thoughts?

Whatever works. :wink: Usually I tend to prefer dialogs over iframes, but there may also be reasons to use an iframe instead. I have to admit, that I'm currently not using this module, though.

robertgarrigos commented 1 month ago

Just looked into this and realized that I had a misunderstanding. This module is using jquery's dialog already, as well core does now. I believe we shouldn't change anything here.