backdrop-contrib / references_dialog

Extends reference fields by adding links to add, edit, and search for references through a dialog.
https://backdropcms.org/project/references
GNU General Public License v2.0
1 stars 3 forks source link

Dependency to References prohobits module update #33

Closed olafgrabienski closed 2 weeks ago

olafgrabienski commented 2 weeks ago

When I try to update References Dialog from version 1.x-1.0.6 to 1.0.9, update.php reports an unresolved dependency regarding the References module. I'm using References Dialog with Entity Reference instead of References, so I'm not able to proceed with the update.

What was the reason to add the dependency to References?

argiepiano commented 2 weeks ago

@olafgrabienski, it looks like @robertgarrigos added this dependency because of a fix he did for an inexistent Backdrop validation callback. He used a function provided by the references module. There is a better fix for that problem that avoids this unnecessary dependency. See #24

argiepiano commented 2 weeks ago

I'm talking about this fix, that was merged recently: https://github.com/backdrop-contrib/references_dialog/commit/ea13c9b6b8b636c5841402578424b724f69e5485

argiepiano commented 2 weeks ago

Actually, that was reverted, but it looks like the dependency was not removed... I may be misinterpreting this.

olafgrabienski commented 2 weeks ago

@argiepiano - Thanks for your input, interesting! Let's see what Robert says.

robertgarrigos commented 2 weeks ago

Yep. fixed.