search

backdrop-contrib / search_api

Provides a generic API for modules offering search capabilities
GNU General Public License v2.0
0 stars 6 forks source link

Fix needed to support a proposed date module fix #24

Closed herbdool closed 1 year ago

herbdool commented 2 years ago

Fix needed to support an update to date module: https://github.com/backdrop/backdrop-issues/issues/4267. There's a simple fix in the d7 queue for it. Would be good to get that fix in here so the date module can be fixed in core.

Thanks!

earlyburg commented 2 years ago

Thanks for letting me know. I will take a look asap.

earlyburg commented 2 years ago

@herbdool - I looked at this. It will take additional time. Please stay tuned. This is actually a bit complex. I'm not sure how I am going to test against a core fix that has not been applied yet unless I branch core and do the update to the date module, then test against it. I am understanding the patch in d7 but I need to figure out how and where this may apply to search_api

jenlampton commented 2 years ago

The core issue has a PR and you can use that for your testing. You can grab a patch version of the PR at https://github.com/backdrop/backdrop/pull/2868.patch if that's easier.

laryn commented 1 year ago

@earlyburg Did you have a chance to look at this? I think the core issue is blocked until this is resolved here.

laryn commented 1 year ago

Core issue has been merged. Closing this one.