backdrop-contrib / search_api

Provides a generic API for modules offering search capabilities
GNU General Public License v2.0
0 stars 5 forks source link

Undefined constant ENTITY_CUSTOM #29

Closed robertgarrigos closed 2 years ago

robertgarrigos commented 2 years ago

This constant is defined in Entity UI module, not entity plus, which defines ENTITY PLUS CUSTOM. A solution would be to add Entity UI as dependency, but it might be easier just to define the constant in the code itself.

robertgarrigos commented 2 years ago

Even better, change ENTITY CUSTOM constant to ENTITY PLUS CUSTOM (https://github.com/backdrop-contrib/entity_plus/issues/115#issuecomment-1065889187)

earlyburg commented 2 years ago

@robertgarrigos this commit from 23 days ago should have fixed this https://github.com/backdrop-contrib/search_api/commit/b99e35882c87660ca37fa3e4fa0f26d59731dc1e In addition, I have verified that there are no instances of this string (ENTITY_CUSTOM) in the search_api and search_api_page module. Latest release is here: https://github.com/backdrop-contrib/search_api/releases/tag/1.x-1.0.06 Closing this ticket, as there is nothing to fix.

robertgarrigos commented 2 years ago

Indeed, latest update fixed this. Thanks.