search

backdrop-contrib / search_api

Provides a generic API for modules offering search capabilities
GNU General Public License v2.0
0 stars 6 forks source link

Switch dropbuttons to use Backdrop's theming #53

Closed laryn closed 1 year ago

laryn commented 1 year ago

It looks like the code includes some customized dropbutton theming that we can maybe remove in favor of Backdrop's dropbuttons.

laryn commented 1 year ago

@argiepiano Are you interested in testing this PR?

argiepiano commented 1 year ago

I'm getting some broken images when I applied this patch to the dev version - perhaps these are broken in the dev version?

Screen Shot 2023-11-29 at 4 41 57 PM
argiepiano commented 1 year ago

@laryn, the culprit is a commit done in October, which removed a trailing slash from $base_path: 5f452a4385b01e6742256b1bf862cf51cfd8c924

Can you perhaps fix this this problem in this PR, since it's somewhat related?

EDIT: lines 48 and 55 need '/' before the file name.

laryn commented 1 year ago

@argiepiano I noticed that, too, and actually included it (although unrelated) in the other PR. Since it's not technically related to either of these PRs and has not been included in any actual release, I'm comfortable leaving it there.

laryn commented 1 year ago

Did everything else look good?

argiepiano commented 1 year ago

Hi. Yes, everything worked fine. Sorry for the delay in responding.