Store values in state rather than config

[argiepiano]

search_api_facetapi uses config to store search ids. See search_api_facets_search_ids and search_api_facetapi.settings.json. These values are likely to change often (probably on each search), and are not user-configurable. Storing them as config is unnecessary and probably costly. They should be moved to state.

I also see a bunch of other config keys that are not used anywhere: date_format_search_api_facetapi_. Those can probably be removed. It's hard to understand the rationale there.

[laryn]

@argiepiano Agreed.

I took a look at the other issue about unused config keys and it seems like this is where it came in: https://www.drupal.org/project/search_api/issues/2677900

For Backdrop we can probably delete all those config keys and include some date format config files in that submodule's config folder to provide those configurable date formats, and use those formats where needed in the module itself.

[laryn]

@argiepiano I've a PR for this one -- can you test?

[argiepiano]

For Backdrop we can probably delete all those config keys and include some date format config files in that submodule's config folder to provide those configurable date formats, and use those formats where needed in the module itself.

Yes, I noticed that D7 required defining variables to store the date type's specific format. This is done differently in Backdrop - I see that you have that already, by putting those new formats inside system.date.json. I had a small question about the need to lowercase those constant values.

The removal of search_api_facets_search_ids looks good also. I can't test right now but will try to get to this later.

[laryn]

Thanks @argiepiano -- I've responded in the PR to your question.

[argiepiano]

About to test now...

[argiepiano]

Tested, looks great. RTBC.

[laryn]

Thanks @argiepiano! Merged.