search

backdrop-contrib / search_api

Provides a generic API for modules offering search capabilities
GNU General Public License v2.0
0 stars 6 forks source link

Support for exportable entity statuses. #6

Closed earlyburg closed 3 years ago

earlyburg commented 4 years ago

We added support in the entity_plus module for statuses in exportable entities. backdrop-contrib/entity_plus#34 This should address two PHP issues that I noticed when viewing pages showing search indices or servers.

fixes the following issues: PHP Notice: Undefined index: status in theme_search_api_index() (line 1027 of /var/www/rvg-web.net/backdrop2/modules/search_api/search_api.admin.inc).

and

PHP Warning: Theme hook "entity_status" not found.

when viewing /admin/config/search/search_api/index/someIndexName

earlyburg commented 4 years ago

@docwilmot I would like to volunteer to take over this project (search_api), with your oversight and input of course.

docwilmot commented 4 years ago

That would be fine with me @earlyburg.

earlyburg commented 3 years ago

Hi @docwilmot, I found these issues which relate to this project: https://github.com/backdrop-contrib/search_api_db/issues/1 https://github.com/backdrop-contrib/search_api_solr/issues/1

I would like to approach these issues by merging this pull request and then one other small code change to merge after that. That action would fix this issue: https://github.com/backdrop-contrib/search_api/issues/7

Then my next step would be to create tests for search_api_solr, and by that hopefully backtrace the Ajax issue. Then I can hopefully apply that fix in a pull request to search_api_db. So, with your permission I am going to merge this pull request. Thanks for your time.

ghost commented 3 years ago

Congrats on helping maintain this project @earlyburg! I recommend you update the README to list yourself as a maintainer.