search

backdrop-contrib / search_api_solr

This module provides an implementation of the Search API which uses an Apache Solr search server for indexing and searching.
GNU General Public License v2.0
0 stars 4 forks source link

Move non-configurable options from config to state #8

Closed argiepiano closed 9 months ago

argiepiano commented 10 months ago

There are a few non-configurable options currently saved as json files that may be better suited for state saving. Reading and writing json files is expensive and slow, and may be causing some of the unusual behavior mentioned here in Zulip.

herbdool commented 10 months ago

@argiepiano I found the hash which is better stored in state (new PR). I'm not sure what else. The recently merged PR also set last_optimize to state.

argiepiano commented 10 months ago

@herbdool I left a comment. Also, please set the hash to state in update 1000.

argiepiano commented 10 months ago

Sorry, it won't be necessary to store this hash in update 1000, since this is done on page request

argiepiano commented 10 months ago

But... we should get rid of the config storage of the hash in that update hook.

herbdool commented 10 months ago

@argiepiano okay done.

argiepiano commented 10 months ago

LGTM