search

backdrop-contrib / seo_meta

SEO Meta Tags module for Backdrop CMS
GNU General Public License v2.0
4 stars 1 forks source link

Open Graph image disappears #19

Closed robertgarrigos closed 6 years ago

robertgarrigos commented 6 years ago

OG images disappear once set. I guess it's something related to cron, as it is not immediate. Seo data is ok in data base, but files in files/og_images are missing. Anyone having this same issue?

robertgarrigos commented 6 years ago

I realise that once uploaded an OG image, it gets listed in /admin/content/files as temporary file. Why is that? All the others are permanent.

findlabnet commented 6 years ago

Thank you for reporting, @robertgarrigos. You are first, who report this issue, I'll check it ASAP.

robertgarrigos commented 6 years ago

Also that image has a use count of zero. Now it's gone again. Coul it be that backdrop, during crons, delete unused images (with zero use count)?

findlabnet commented 6 years ago

You right, there is wrong file saving behavior, I'll fix it tomorrow.

robertgarrigos commented 6 years ago

I realize that you changed seo_meta_node_presave() function to seo_meta_node_insert(). then when you update the node with a new og image the insert hook doesn't take place. By changing back to _presave I fixed this problem. Any reason to change it to _insert()?? I filled a PR.

findlabnet commented 6 years ago

Tomorrow is not tonight ;-) thank you!

robertgarrigos commented 6 years ago

Tomorrow is not tonight: sorry, I was sending comments without refreshing the page and didn't see yours :-)