backdrop-contrib / seo_meta

SEO Meta Tags module for Backdrop CMS
GNU General Public License v2.0
4 stars 1 forks source link

Put all config into config files #25

Closed yorkshire-pudding closed 1 year ago

yorkshire-pudding commented 1 year ago

I note some config is in settings but some is in database. Is there a reason for this?

It would be easier for deployment and version control if all could be in config

findlabnet commented 1 year ago

Thanks for for reporting, I'll check it as soon as possible.

findlabnet commented 1 year ago

@yorkshire-pudding, thank you for your valuable help and interest. In the database, I only store the tag values themselves, which are not "settings", so it's not clear to me what you mean.

yorkshire-pudding commented 1 year ago

I think metatags and metatag patterns are config; they're not content. As these are set at a high level rather than per node and they're also not a state, I think they should be in config. In the metatag module, all the tags and settings are stored in config.

findlabnet commented 1 year ago

This module is NOT intended to completely replace or repeat all the functions of its "big brother" ("Metatag" module) - only the necessary minimum set of functions.