Keep track with latest SMTP 7.x-1.7 version in D7

[herbdool]

Changes since 7.x-1.3

• [x] Removes SendmailSend() from smtp.phpmailier
• [x] #2724331 by JeffM2001, dang42: "From Name" no longer works in v1.4
• [x] #2720015 by DamienMcKenna, hossein425, wundo, rcodina, vitalblue, ptmkenny, ehj-52n: Fatal error when sending emails
• [x] #2226483 by bago, DamienMcKenna, alex_drupal_dev, wundo: Backup configuration doesn't work (bundled PHPmailer issue)
• [x] #2299479 by DamienMcKenna, ben_chad, jordanpagewhite, alex_drupal_dev, wundo: Use form submit handler to send test email
• [x] #1847678 by DamienMcKenna, wundo, matthiasm11, alex_drupal_dev, gadaniels72, janton: SMTP server failure, no retry?
• [x] #2651398 by DamienMcKenna, gadaniels72, jordanpagewhite, wundo: Add option to reroute all email to a single address
• [x] #2670760 by DamienMcKenna, NancyDru: Please remove Hook_update_N() from update doc
• [x] #2720015 by DamienMcKenna, rcodina: Fatal error when sending emails
• [x] #2716985 by jenlampton, wundo: Check for dblog module (and access?) before providing link
• [x] #2653398 by wundo: Using the TRUE/FALSE instead of 0/1 on form builder
• [x] #2653398 by DamienMcKenna: Add option to not actually deliver emails
• [x] #2698029 by wundo: Fixes watchdog not being logged for messages which skips the queue
• [x] #2656510 by arnested, DamienMcKenna, alex_drupal_dev, estoyausente: Make hostname and HELO configurable
• [x] #2556369 by jurgenhaas, DamienMcKenna, wundo: Whitespace in header values could break functionality
• [x] #1953134 by DamienMcKenna, alex_drupal_dev, gadaniels72, wundo: Use autocomplete="off" attribut for SMTP Authentication fields
• [x] #2274571 by DamienMcKenna, Jaypan: Implement hook_variable_info
• [x] #2701263 by tcarmona: Typo inside the SMTP server address error
• [x] #2701267 by tcarmona: Typo inside the SMTP port number error
• [x] #2701203 by tcarmona: Typo inside the SSL description
• [x] #2681999 by TuWebO, dineshw, wundo, nidhi.badani: SMTP Error: Invalid address, but address not shown in watchdog
• [x] #2596413 by ivanstegic, sammuell, DamienMcKenna, alex_drupal_dev, wundo: From header is not correctly handled
• [x] #2653394: Adding missing files
• [x] #2653394 by DamienMcKenna, jordanpagewhite: Integration with Maillog
• [x] #2497359 by DamienMcKenna, jrreid, alex_drupal_dev, gadaniels72, wundo: For debugging, use drupal_set_message instead of printing directly to the output
• [x] #1889278 by DamienMcKenna, Simon Georges: Remove smtp_library variable from 7.x-version
• [x] #2651406 by DamienMcKenna, alex_drupal_dev, gadaniels72: Incorrect variable used when logging all messages
• [x] #2309875 by COBadger, DamienMcKenna: Error in 'from' using site-wide contact form and multiple recipients
• [x] #2548133 by rrfegade, DamienMcKenna, wundo: Remove unused varibles from D7
• [x] #2653386 by DamienMcKenna: Add some tests

[jenlampton]

There were a lot of releases of the SMTP mailer module for Drupal 7 (starting with 7.x-1.4) that effectively broke the functionality for a while, so I decided not to implement those same changes in the Backdrop version to keep our module in a usable state.

Since then, the Drupal 7 version of SMTP has been fixed, so it might be worthwhile to review all the commits since 1.3 and see which are worth pulling over into the Backdrop version. Let's use this issue as a meta to track the changes we want to include.

[herbdool]

My PR (above) brings it to 1.7. In my tests it seems to be working fine. Plus we've got the Drupal version working on client sites with no trouble.

[jenlampton]

Ah, you're 2 steps ahead of me! :)

[herbdool]

Yup! Though I forgot to run the tests so I can fix those up first.

[herbdool]

humph. I took a look at the test. Turns out it relies on Maillog which would need to be ported. I might port it at any rate but means a delay. However, if we test it by hand it's probably just as good at least for the initial upgrade.

[herbdool]

Alright, SMTP tests are passing! I ported Maillog so I could run the tests and I'll upload Maillog to github soon as well.

[jenlampton]

you're on 🔥

[herbdool]

I've confirmed all the commits you identified above are in the PR.

[jenlampton]

I've merged in the PR. I'd like to leave it for at least a week before making a release, so others (mostly myself) can test it in the wild.

[jenlampton]

Thanks @herbdool for all your work on this!

[Graham-72]

I am doing some testing and so far have found no problems with this SMTP module but I have found and fixed a bug in Mailsystem module!

[herbdool]

@Graham-72 can you report the bug if you haven't already?

[jenlampton]

Closing as a new release will contain these changes. 🎉