backdrop-contrib / smtp

Backdrop CMS port of the SMTP module for Drupal 7
GNU General Public License v2.0
4 stars 5 forks source link

PHP 8 compatibility #34

Open indigoxela opened 7 months ago

indigoxela commented 7 months ago

Some issues have been fixed in D7, but there's more.

This issue here combines several PHP 8 compat tasks.

indigoxela commented 7 months ago

PHPStan finds a lot more to nag, but here we address the "undefined property" issues:

They're possible not used often, but finding these violations is the benefit of static analysis. :wink:

herbdool commented 7 months ago

The PR looks good. RTBC.

I'll add that it also removes reference to safe_mode which was removed in PHP 5.4.

yorkshire-pudding commented 2 months ago

I also confirm this works. Please can this be merged and released @jenlampton