backdrop-contrib / socialfield

The Social field module provides a field that allows you to collect links to social network profiles like facebook, twitter, google+, linkedin, etc.
GNU General Public License v2.0
2 stars 4 forks source link

Wrong getter and setter function name #28

Open laryn opened 1 month ago

laryn commented 1 month ago

I was searching my code and saw this. I don't have steps to reproduce anything but noticed that these getter and setter function names are wrong:

Reference: https://github.com/backdrop-contrib/entity_plus/issues/33#issuecomment-984298911

laryn commented 1 month ago

~That would also mean a dependency on Entity Plus.~

argiepiano commented 1 month ago

The fix is correct, but there is no need to depend on Entity Plus. The way it works:

Enabling Entity Plus would allow someone to use entity metadata wrappers to set the field values. But this is not required for the module to function.

argiepiano commented 1 month ago

To clarify, this change should be done, but there is no need to depend on E+

laryn commented 1 month ago

Thanks @argiepiano!