search

backdrop-contrib / spambot

Anti-spam module that uses data from www.stopforumspam.com to protect the user registration form against known spammers and spambots.
GNU General Public License v2.0
0 stars 2 forks source link

spambot_last_checked_uid should be saved in state system, instead of config system #4

Open jenlampton opened 2 years ago

jenlampton commented 2 years ago

Every time I check on one of our b.org sites, I show a change in the live config file for config/live-active/spambot.settings.json that I didn't make. The value that changes is spambot_last_checked_uid which I believe is a timestamp. Since I expect this timestamp to be unique for every site running the module, this value should probably be stored as state, and not configuration (to be deployed across sites).

The variables table was often used for both state and config in Drupal 7, so there was no reason to differentiate the two. I cmmonly only find these state values until after I have sites running the modules, where they show up as config changes on production :)

jenlampton commented 2 years ago

I'm testing this patch on the forum site. FYI @bugfolder

bugfolder commented 2 years ago

FYI @jenlampton I will also add it to b.org, where we're also seeing the config constantly changing for the same reason. See also suggested edit to the PR.

jenlampton commented 2 years ago

I've merged your recommended change to the PR :) thank you!