backdrop-contrib / stanford_decanter

Decanter 7 Stanford theme for Backdrop CMS
GNU General Public License v2.0
1 stars 0 forks source link

Padding of header and min-width in @media query #3

Closed argiepiano closed 2 days ago

argiepiano commented 2 months ago

Thanks for this beautiful theme!

I see the following lines in main.css. Is this a typo? These are nested media queries - none of the queries for screens smaller than 768px will ever run. My feeling is that these queries for smaller than 768px screens should not be nested inside @media (min-width: 768px){} - unless I'm missing something here.


@media (min-width: 768px){
  .l-header .l-header-inner{
    padding-left: 20px;
    padding-right: 20px;
    margin-left: auto;
    margin-right: auto;
  }

  @media (min-width: 576px){
    .l-header .l-header-inner{
      padding-left: 30px;
      padding-right: 30px;
    }
  }

  @media (min-width: 768px){
    .l-header .l-header-inner{
      padding-left: 50px;
      padding-right: 50px;
    }
  }

  @media (min-width: 992px){
    .l-header .l-header-inner{
      padding-left: 80px;
      padding-right: 80px;
    }
  }

  @media (min-width: 1200px){
    .l-header .l-header-inner{
      padding-left: 100px;
      padding-right: 100px;
    }
  }

  @media (min-width: 1500px){
    .l-header .l-header-inner{
      padding-left: 100px;
      padding-right: 100px;
    }
  }

  @media only screen and (min-width: 1700px){
    .l-header .l-header-inner{
      padding-left: calc((100% - 1500px)/2);
      padding-right: calc((100% - 1500px)/2);
    }
  }

   .centered-container .l-header .l-header-inner,.l-header .l-header-inner .centered-container,.l-header .l-header-inner .md\:cc{
    padding-left: 0;
    padding-right: 0;
  }

  .l-header .l-header-inner{
    padding: 0;
  }
}
irinaz commented 1 month ago

@argiepiano , thanks for adding this issue. We rebuilt theme (now it does not based on Basis). Please let us know if you still see this issue.

irinaz commented 2 days ago

@argiepiano , we have new release with more fixes - please re-open this ticket of you still see issues. We are doing demo on https://opensource.su.domains/