search

backdrop-contrib / stripe

This module provides a simple abstraction to use the Stripe PHP SDK.
GNU General Public License v2.0
2 stars 2 forks source link

Bundle the Stripe PHP bindings into this module #1

Closed jenlampton closed 7 years ago

jenlampton commented 7 years ago

Since the MIT license is GPL-compatible, this external library should be bunded with the stripe module to make life easier on developers + end-users alike.

jenlampton commented 7 years ago

Well, I started working on a PR for this, but then realized this isn't the module I needed. I'm going to switch to webform_stripe, but I'll leave this PR incase this is the direction you want to go in the future :)

laryn commented 7 years ago

@jenlampton See the other comment thread RE: webform_stripe. I'm guessing there's something there that we can continue from, even if we rename it back to webform_stripe.

Bundling the library is a good idea.

jenlampton commented 7 years ago

As my first act as co-maintainer I'm going to merge the PR for bundling the library to remove a dependency on libraries module. https://github.com/backdrop-contrib/stripe_api/pull/2 :D