search

backdrop-contrib / tatsu

A basic flexible theme inspired by Basis theme in Backdrop CMS Core
GNU General Public License v2.0
2 stars 5 forks source link

Need to remove border bottom from first item primary menu. #65

Closed izmeez closed 11 months ago

izmeez commented 1 year ago

There is a 1px grey border-bottom visible on the first item in the primary menu. It appears to be related to code in css/basis-component-colors.css

`/ components/menu-dropdown.css /

.js .menu-dropdown li, .js .menu-dropdown a.has-submenu.highlighted { border-bottom: 1px solid #bbbbbb; } `

It only appears on the first item "Home" and shows even when another item is selected. Removing the line appears to fix the issue. tatsu-primary-menu-first-element-bkgnd-bottom-edge

izmeez commented 1 year ago

Actually, removing the line .js .menu-dropdown li, from the code below so the attribute does not apply to this element is all that's needed. However, the real cause may be elsewhere as the code below is similar to what is in the core Basis theme where this issue is not present. `/ components/menu-dropdown.css /

.js .menu-dropdown li, .js .menu-dropdown a.has-submenu.highlighted { border-bottom: 1px solid #bbbbbb; } `

Wylbur commented 11 months ago

The basis-componenet-colors.css included the initial setting for a bottom border color, but in the original file, there is also a media query removing that style on large displays:

@media (min-width: 48em) {
  .js .menu-dropdown li,
  .js .menu-dropdown a.has-submenu.highlighted {
    border-bottom: none;
  }
}

We can add this additional CSS to the file to resolve this issue.