search

backdrop-contrib / taxonomy_menu

Adds links to taxonomy terms into a menu.
GNU General Public License v2.0
0 stars 3 forks source link

Taxonomy Menu rebuild process encountered an error - version 1.x-1.53 #11

Open jvillacriz opened 1 year ago

jvillacriz commented 1 year ago

There is an error in version 1.x-1.53 image

image

As a result, the taxonomy menu cannot be displayed in the default layout.

But version 1.x-1.52 works fine.

Wylbur commented 9 months ago

I'm also getting this error when I install Taxonomy menu from scratch. This is the error that is generated when I try to save a taxonomy term:

Too few arguments to function taxonomy_menu_handler(), 2 passed in /home/twincitiesamnest/ai37/web/modules/taxonomy_menu/taxonomy_menu.module on line 458 and at least 3 expected

During the install, the same errors as in comment one, and the errors below when trying to save changes to any items in a vocabulary assigned to a taxonomy menu.

This is the module unusable.

jvillacriz commented 9 months ago

Try version 1.x-1.52

albanycomputers commented 7 months ago

Same problem here... tried with php8 and other issues... 1.5.2 works for me.

eric2pin commented 3 months ago

Same problem, module throws fatal error when enabled on a taxonomy / while trying to generate the links. I submitted a pull request that's fixing the issue for me.

nattywebdev commented 2 weeks ago

I applied the same fix as referred to by @eric2pin - it fixed this issue for me too, except my two-level taxonomy vocab is flattened into one level in the menu.

argiepiano commented 2 weeks ago

I can confirm @nattywebdev's decribed behavior after adding @eric2pin's fix. When rebuilding the menus, all levels are flattened.

argiepiano commented 2 weeks ago

@nattywebdev I've opened a new issue for this flattened menu problem. #13.

I'll provide a PR in a few minutes. Can you please test?

nattywebdev commented 2 weeks ago

Sure can - let me know when it's ready.

argiepiano commented 2 weeks ago

I've submitted a more comprehensive PR that fixes this problem and also the term hierarchy issue #13. You may want to close this PR.

argiepiano commented 2 weeks ago

@nattywebdev to test, please patch the dev version with PR #14

argiepiano commented 2 weeks ago

@nattywebdev to test, you will need to:

  1. Use the dev version (1.x-1.x), not the latest
  2. REVERT PR #12 if you applied it before. The PR #14 actually also fixes that
  3. Apply PR #14
nattywebdev commented 2 weeks ago

Thanks for that info. I had uninstalled the taxonomy menu module as I didn't appreciate there would be this quick a fix, so applying #14 should be straightforward. I'll feed back shortly.

nattywebdev commented 2 weeks ago

Re-installed, manually patched and linked to a menu and I can confirm my two-level taxonomy is replicated correctly in the menu. Thank you so much!