Figure / image / figcaption revisited

[indigoxela]

There's some room for improvement with figure / figcaption.

According to developer.mozilla.org figcaption may contain a lot more than we allow now. But we also can't allow all valid elements, as that would break compatibility to CKE (4 and 5, core), which in turn would lead to odd situations, when toggling between editors (OK, v5 allows less than v4).

However, currently Tiny (the library) allows to add whatever's actually valid, but toggling source mode (as an example, anything that triggers conversion to data attribute), the paragraphs are gone. And that's odd from user perspective.

Another problem: if a figure with image and figcaption is the only element in the editor, it's a bit tricky to escape (get the cursor outside the figure). EDIT: it's hitting an keyboard arrow button twice. :wink:

Another problem: how in the world did I manage to introduce a similar linked-image-in-figure bug as core CKE5 has? (The link from caption content slips to the image, the link from the image (if any) to the caption.) Fix that.

Nested markup in caption's also broken - they get stripped when saving. Not nice.

See also:

• tinymce.activeEditor.schema.isValidChild('figcaption', 'p')
• https://www.tiny.cloud/docs/tinymce/latest/apis/tinymce.html.schema/
• https://www.tiny.cloud/docs/tinymce/latest/content-filtering/#example-using-valid_children

[indigoxela]

Fixed so far:

• Links from figcaption get wrapped around image - fixed by filtering the link list
• Stricter handling for content allowed in figcaption (schema alteration) to get results closer to what CKE4 had
• Simplified figcaption parsing to use Tiny's tools
• Extend figcaption serializer to also take more and nested tags into account

Still pending:

Function captionAstNodeToString() grew quite a bit. Not sure if I can simplify that. Probably not.