search

backdrop-contrib / tinymce

Integration for the TinyMCE editor in Backdrop CMS
https://backdropcms.org/project/tinymce
GNU General Public License v2.0
2 stars 1 forks source link

Run some checks via GHA #81

Closed indigoxela closed 5 months ago

indigoxela commented 5 months ago

This module has no automated tests, but phpcs and possibly jshint are good candidates to run on PRs.

indigoxela commented 5 months ago

Nice! It works.

But 72 errors with jshint. Hm, better fix them in a follow-up.

indigoxela commented 5 months ago

Just realized, there's an unused var in code-checks.yml, or more precisely, an obsolete step.

And when I'm at it - workflow and job with the same name look odd.

... And when I'm at it - check if newer phpcs version (new maintainership!!) are available via shivammathur/setup-php@v2 :wink: