Ubercart/Filefield Paths crash (stdClass instead of entity)

[bugfolder]

The error message is:

Message | Error: Call to undefined method stdClass::bundle() in filefield_paths_field_storage_pre_update() (line 363 of mysite/modules/contrib/filefield_paths/filefield_paths.module).

Further details and discussion in the original FFP issue: https://github.com/backdrop-contrib/filefield_paths/issues/27

H/T @argiepiano

[bugfolder]

Some notes here. Per @argiepiano's comment, I can reproduce this error in an installation with filefield_paths module installed if I

• Create a new order, then add a blank line to the order

Also:

• Edit an existing order, then change something for one of the line items and save. The missing-bundle happens for every product in the order, not just the altered one.

This is all consistent with @argiepiano's description of what's going on and what needs to be fixed.

[bugfolder]

Using entity_create in uc_order_edit_products_add_blank() fixes the problem with adding a blank line.

However, in the case of editing an existing order, the stdClass is still there (giving rise to a missing bundle() method), and comes from a cast to object in uc_order_pane_products() (lines 245–251):

    case 'edit-process':
      if (isset($form_state['values']['products'])) {
        foreach ($form_state['values']['products'] as $key => $product) {
          $product['data'] = unserialize($product['data']);
          uc_order_product_save($order->order_id, (object) $product);
        }
      }

There's lots of stdClass and (object) $something throughout UC, so there may be more of this situation lurking about.

[argiepiano]

I can take a look tonight. Many of the stdClass uses are not fieldable entities. This one is.

[argiepiano]

@bugfolder I'm submitting a PR. This needs thorough testing just to be sure it doesn't break other things.

In addition to using entity_create() in uc_order_edit_products_add_blank() (which you tried), it stores the existing uc_order_product entities present in the order in the $form_state array, so that they can be retrieved in the submit handler handled by the 'edit-process' op. That handler basically sets the values of the entity object properties, and uses that entity object to send to uc_order_product_save() instead of a stdClass object.

[bugfolder]

Testing:

• Add a blank line, fill it in, save; no problem, data is saved.
• Edit an existing product in the order, save: no problem, and the changes are present after saving.

However:

• Click "Add product," select one, click "add to order," it appears, then save. Result is a crash with this error:

Warning: Undefined array key 105642 in uc_order_pane_products() (line 248 of /mysite/modules/contrib/ubercart/uc_order/uc_order.order_pane.inc). Error: Attempt to assign property "remove" on null in uc_order_pane_products() (line 250 of /mysite/modules/contrib/ubercart/uc_order/uc_order.order_pane.inc).

[argiepiano]

Hmmm... I'm able to add products normally. But I'm working with a vanilla install of Ubercart without anything else. Can you let me know what other uc modules you have enabled?

[EDIT] OK, I think I can reproduce. Will look more into this.

[argiepiano]

@bugfolder, here's a different approach. There is no need to store the products in the $form_state (in fact, that let to the issue you found, since a Node object is stored there when a normal product is added). So, now, in order to populate their new values, products are pulled from the order itself. The $order object contains the new products nd blank line items as UcOrderProduct objects already by the time it reaches the processes in 'form-process'.

Please test.

[bugfolder]

Ran all those same tests (and a few more CRUD actions on the admin order page). All worked. LGTM.