search

backdrop-contrib / ubercart

A flexible but easy-to-use e-commerce system for Backdrop.
https://backdropcms.org/project/ubercart
GNU General Public License v2.0
4 stars 10 forks source link

Replace Store CSS icon in admin bar with Phosphor icon in Backdrop 1.28.0+ #499

Closed bugfolder closed 6 months ago

bugfolder commented 6 months ago

With the addition of admin bar icons in Backdrop 1.28.0, there is now a double-icon on the Store menu in the admin bar: the original CSS icon of a cart, and the generic core icon.

image

We can replace the CSS icon with the shopping-cart-fill or shopping-card-simple-fill icon from core icons.

Since there are bugfixes to come in the next release, making the next UC release dependent on Backdrop 1.28.0 seems overly restrictive. Can we check the B version and on that basis decide whether to use the core icon or CSS icon?

bugfolder commented 6 months ago

PR added. For Backdrop < 1.28.0, the menu bar looks like this:

image

And for 1.28.0 and higher, it looks like this:

image

bugfolder commented 6 months ago

BTW, automated tests failed for an unrelated reason, so I've fixed the failing test in the PR.

laryn commented 6 months ago

LGTM!

bugfolder commented 6 months ago

Thanks, I'll take your "LGTM" is an indication of RTBC and have updated the label. (Any chance you or @argiepiano could check the other "maintainer review requested" issues?)