search

backdrop-contrib / uc_stripe

Ubercart payment gateway module for Stripe.
0 stars 1 forks source link

Stripe payment pane not collapsible in checkout #9

Open nattywebdev opened 7 months ago

nattywebdev commented 7 months ago

When choosing to have collapsible panes in checkout from admin/store/settings/checkout, the Stripe Payment pane is not collapsible.

This is caused by line 317 of uc_stripe.module (shown with ** below):

function uc_stripe_uc_checkout_pane() {
  $panes['payment-stripe'] = array(
    'callback' => '_uc_stripe_payment_pane_callback',
    'title' => t('Payment Information'),
    'desc' => t("Accept stripe payment from customer."),
    'weight' => 6,
    'process' => FALSE,
    **'collapsible' => FALSE,**
  );
  return $panes;
}

Changing this to TRUE allows the pane to be collapsible as necessary.

Was this set that way for a reason? If not, can it be changed so that it works as expected?

laryn commented 7 months ago

I don't see a reason not to -- it came over that way from Drupal 7 but I don't know of any special reason for it, especially if you've tested this change and things are working well. Care to make a PR?

nattywebdev commented 7 months ago

@laryn I believe I've created a PR https://github.com/backdrop-contrib/uc_stripe/pull/10 to fix this issue, as advised by @argiepiano . I'm very much a novice at this so do tell me if I've done anything wrong!