search

backdrop-contrib / userprotect

Allow fine-grained access control of user accounts by providing various account editing protections.
GNU General Public License v2.0
0 stars 0 forks source link

Errors on defaults tab #1

Closed herbdool closed 4 years ago

herbdool commented 4 years ago

Screenshot from 2020-08-21 14-30-10

I see this error right after installing on a fresh site. I haven't changed any settings. I haven't dug in further.

herbdool commented 4 years ago

The userprotect.settings.json file is not correct.

laryn commented 4 years ago

Ah, good catch. Forgot to clean that up after Coder Upgrade created it...

herbdool commented 4 years ago

@laryn I created a PR

herbdool commented 4 years ago

I think there's also an issue with the release. It doesn't look right in github, just says "tag". And drush can't download it.

herbdool commented 4 years ago

Looks like .install also needs updating. I'll add that.

laryn commented 4 years ago

I think there's also an issue with the release.

Maybe because I checked the box that said "Pre-release"? Just guessing. I knew it wasn't completely tested yet...

herbdool commented 4 years ago

I've also updated the .install - needed proper defaults and was missing $config->save() (is this because coder upgrade is missing it?). And fixed the hook_config_info()

laryn commented 4 years ago

Thanks @herbdool ! Yes, that looks like what was spit out by Coder Upgrade. Been meaning to file an issue about some of those so they don't happen every time. Clearly I didn't walk through the clean up phase in as much depth as usual on this one...

laryn commented 4 years ago

Looks like you found some of them before, too: https://github.com/backdrop-contrib/coder_upgrade/issues/26

herbdool commented 4 years ago

I tend not to use coder_upgrade since it's easy to miss things that still need to be fixed.

herbdool commented 4 years ago

I've tested the PR locally so I think it's working.

laryn commented 4 years ago

@herbdool thanks! Looks great and since there was no formal release yet I've merged without testing. If you're about to use/test further please let me know of any other bugs you may find. If it's running well for you I'll make a new release.

herbdool commented 4 years ago

sounds good. I tested it on a client site. So far I'm not sure it's working properly - it's not blocking a user from actually changing fields - so I'll have to test again locally. Maybe I don't understand how it works.

laryn commented 4 years ago

The interface is a little strange for sure. I haven't even thought about improving that yet, just trying to get parity first. :)

(I'm not using it on Backdrop yet but will be in the future when a D7 site I support gets updated.)

herbdool commented 4 years ago

I read the wiki - so I think it is working correctly. However, not as I expected. I think I'm only interested in the permissions the module provides - want to prevent a role from editing their own accounts. (I had advised our client not to go this route, but, sigh, ...)

laryn commented 4 years ago

(I had advised our client not to go this route, but, sigh, ...)

I certainly know that feeling.

laryn commented 4 years ago

@herbdool What do you think of the UI in these screenshots? https://github.com/backdrop-contrib/userprotect/issues/3

herbdool commented 4 years ago

I like them. Though now my client won't be using them. I convinced them to take a different approach, using Backdrop and CiviCRM.