Closed herbdool closed 8 months ago
@herbdool I made an alternate PR to try to clarify the menus. See what you think. If possible, I'd like to keep the VEF menu items all contained together to prevent menu sprawl.
https://github.com/backdrop-contrib/video_embed_field/pull/32
@laryn If admin_bar
module isn't enabled, there's still no way to get to that settings page, except by typing in the path. All you see is:
How about you also change the menu to MENU_LOCAL_TASK
:
$items['admin/config/media/vef/settings'] = array(
'title' => 'Settings',
'description' => 'Video Embed Field settings',
'page callback' => 'backdrop_get_form',
'page arguments' => array('video_embed_field_settings_form'),
'file' => 'video_embed_field.admin.inc',
'access arguments' => array('administer video styles'),
'type' => MENU_LOCAL_TASK,
'weight' => 10,
);
Then it appears as a tab:
That works.
And it's also linked from the module page:
@laryn looks good
In
hook_menu
,admin/config/media/vef/settings
is defined asMENU_NORMAL_ITEM
but I don't see it appearing. Maybe Preset API interferes with this?I think the easiest is to make the settings a different path. Perhaps just
admin/config/media/vef-settings
. That's similar to how images are done: the styles are a separate menu item.