search

backdrop-contrib / video_filter

A Backdrop CMS port of drupal.org/project/video_filter, a highly flexible and easily extendable filter module to embed any type of video in your site using a simple token.
GNU General Public License v2.0
2 stars 2 forks source link

Function _video_filter_instructions() doesn't account for disabled filter #32

Open indigoxela opened 1 week ago

indigoxela commented 1 week ago

That function builds the instructions fieldset by looping over all formats and grabbing the enabled codecs.

However, it doesn't account for disabled status of that filter in a format, which leads to all codecs showing up in instructions, if one of the formats doesn't have the video filter enabled at all.

That's not new, only caused me some head scratching today with the latest update. :wink:

indigoxela commented 1 week ago

Here's a PR that adds the check.