search

backdrop-contrib / video_filter

A Backdrop CMS port of drupal.org/project/video_filter, a highly flexible and easily extendable filter module to embed any type of video in your site using a simple token.
GNU General Public License v2.0
2 stars 2 forks source link

quick and dirty getting ckeditor plugin working #9

Closed herbdool closed 1 year ago

herbdool commented 5 years ago

Addresses #8

herbdool commented 5 years ago

@Radcliffe thanks for your other PRs. I'm wondering if you want a mini-project. I got the ckeditor button working in this PR but there are issues. On the front-end the button shows up and can click to get the dialog. On the backend the button image isn't visible but can be moved to the ckeditor toolbar.

Also, should use the built-in ckeditor dialog (like is done in core for BackdropLink) instead of the custom solution in this module. Part of this is using video_filter_ckeditor_settings_alter() hook instead of video_filter_element_info_alter() hook. And part is changing plugin.js so it uses the ckeditor dialog.

This isn't an easy bit work since there's no guidebook for the ckeditor plugins but can figure most things out by looking at core.