search

backdrop-contrib / views_bootstrap

This module provides a set of styles for the Views module. It allows you to create responsive Bootstrap 3.x components, such as grids, carousels, tabs, and tables, all within the configuration settings of the powerful Views module.
https://backdropcms.org/project/views_bootstrap
GNU General Public License v2.0
0 stars 7 forks source link

Generic text row field or conditional field can't be used on Tabs values #17

Closed Radcliffe closed 5 years ago

Radcliffe commented 6 years ago

Needs review. Based on https://www.drupal.org/project/views_bootstrap/issues/2742547#comment-12607711

stpaultim commented 5 years ago

https://github.com/backdrop-contrib/views_bootstrap/issues/16

daggerhart commented 5 years ago

Ha! Coincedentally, I'm the one who RTBCed that issue on d.o. I remember dealing with this on a D7 site and the fix is obvious imo.

->get_field() renders the output of the field, while ->get_field_value() deals with the raw values. I can't think of a reason why you wouldn't want the rendered field value. If you look at all the other template_preprocess_* functions in theme.inc, they all use ->get_field() instead of ->get_field_value()... except the tabs plugin.

I haven't tested the patch, but it makes perfect sense to me. Considered this reviewed +1.